Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

237 edit profile picture and name #462

Merged
merged 39 commits into from
Aug 18, 2022

Conversation

mikozet
Copy link
Collaborator

@mikozet mikozet commented Jul 22, 2022

Closes #421

@llunaCreixent
Copy link
Member

llunaCreixent commented Jul 25, 2022

note that the user data cannot be updated until the Safe is deployed and signed up to the Hub

@mikozet mikozet marked this pull request as draft July 29, 2022 12:43
@mikozet
Copy link
Collaborator Author

mikozet commented Jul 29, 2022

note that the user data cannot be updated until the Safe is deployed and signed up to the Hub

Thanks for reminding. That case is covered by redirection - if safe is not deployed user will end up on /welcome, /validation pages so I guess we are fine here

@llunaCreixent
Copy link
Member

I was testing in local dev env, and just after registering (in validation view), The username wasn't there, and instead the safeAddress. Then after I refreshed, I was able to see my username in the validation view.

@mikozet
Copy link
Collaborator Author

mikozet commented Aug 8, 2022

Hey @llunaCreixent yes we have this registered as an issue here: #421

@mikozet mikozet marked this pull request as ready for review August 17, 2022 13:02
Copy link
Member

@llunaCreixent llunaCreixent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! But I added com comments

  • ✅ Tests: PASS
  • ✅ Lint: didn't pass but I added a commit

locales/en.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@llunaCreixent
Copy link
Member

If my username was "miko" and I wanted to edit to "Miko", I should be able to do it as long as the username with other case variations is not taken by other account. Right now it says that the username is taken, but actually it's not used by other account, so it should be allowed (unless ther's other user with username "MIKO" or similar)

…sUBI/circles-myxogastria into 237-edit-profile-picture-and-name
@llunaCreixent
Copy link
Member

If my username was "miko" and I wanted to edit to "Miko", I should be able to do it as long as the username with other case variations is not taken by other account. Right now it says that the username is taken, but actually it's not used by other account, so it should be allowed (unless ther's other user with username "MIKO" or similar)

That is what I check in the API side: https://github.com/CirclesUBI/circles-api/blob/c68f5b483fd46101394a5fef60e959ad29341659/src/controllers/users.js#L92

But maybe it's ok if it's not in the frontend. MAybe ask @triaslucia ??

@llunaCreixent
Copy link
Member

Shall we add in the Description of this PR, "Closes #421" ??

Copy link
Contributor

@JacqueGM JacqueGM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved now for real, functionality works!

@mikozet
Copy link
Collaborator Author

mikozet commented Aug 18, 2022

If my username was "miko" and I wanted to edit to "Miko", I should be able to do it as long as the username with other case variations is not taken by other account. Right now it says that the username is taken, but actually it's not used by other account, so it should be allowed (unless ther's other user with username "MIKO" or similar)

I created issue for that:
CirclesUBI/circles-core#135

@mikozet
Copy link
Collaborator Author

mikozet commented Aug 18, 2022

no let's leave it I need to test it and probably add a little additional code in one place..
It will come in next PR when I add email ...

@mikozet mikozet merged commit 31b13c5 into development Aug 18, 2022
@llunaCreixent llunaCreixent deleted the 237-edit-profile-picture-and-name branch August 18, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants